Skip to content

Keep the references to a lambda parameter's generics in struct fields and inner pairs - #447

Merged
Rigidity merged 1 commit into
rigidity/inference-restructure-13e7from
rigidity/inference-restructure-13e8
Nov 19, 2026
Merged

Rigidity merged 1 commit into
rigidity/inference-restructure-13e7from
rigidity/inference-restructure-13e8

Conversation

@Rigidity

@Rigidity Rigidity commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Part of #362 (step 13e, layer 8 of 9).

13e.4 (#441) wraps the callee's generics in an untyped lambda parameter's type as references, so that a bound on the lambda's return type reaches them. A field access kept the reference only when the element was the reference itself. Now wrapped_at keeps the element as it was before substitution in two cases:

  • for first/rest, whenever a reference is anywhere in the element, through pairs, unions and structs;
  • for a struct field, walking the struct's own pairs along the field's path.

The kept type is the same type as the substituted one, so only the call's generic inference sees the difference. Newly compiled cases:

  • let r: (5, Int) = nested_map(fn(p) => p.first, 5) with p: ((A, Int), Int), and p.first.first;
  • wrapper.value and last.value with Wrapper<A> and Last<A> parameters;
  • p.first with p: (Wrapper<A>, Int) and p: ((A, Int) | nil, Int).

A field that doesn't reference the generic, such as wrapper.other: Int, isn't narrowed, and that's pinned.

Left as is (provisional): references aren't kept through aliases (first of a List<A>) or unions of struct copies.

The stack (#362 step 13e, layers 6–9)

These layers close the gaps that the merged 13e layers (#438–#442) left, so the generics campaign ends with no follow-ups. Each layer is its own PR:
6. An argument's expected type counts when it's what the call's solution has to be: wrap(map(fn(x) => x, 5)) with (5, Int) expected.
7. List items past the end of the expected pairs: first(([2], [3, make()])).
8. Struct fields and inner pairs keep a lambda parameter's generic references.
9. A lambda's shared or caller generics are instantiated when its body captures none of their values: the soundness limits that 13e pinned.

Fuzzer, per layer. infer-fuzz --compare against baselines from main 6aea07a5, on all four configurations (generators 1 and 2, seeds 0..4000 and 4000..8000). Every layer has 0 regressions and 0 unsound variants, changes no variant that main infers, and leaks no {generic N}. Newly inferred variants, cumulative: 37 (6), 40 (7), 40 (8), 143 (9). The top PR has the full table.

Breaking changes. None. No program that compiles on main changes its type, CLVM output or diagnostics. Pinned errors that now compile get the type that explicit instantiation gives, and each is a test.

Review. Three rounds:

  • Round 1 (three reviewers):
    • Three conditions in layer 6 had no test. Two are pinned now, and the third, that no later argument writes the generic, is dropped, since it only rejected sound programs.
    • Layer 7 also fired where the expected type goes on as Any; it's limited to a real list end now.
    • Layer 9's alternative solve lost the instantiation of a lambda before its value, which is fixed.
  • Round 2 (three reviewers): a blocker in layer 9. In a recursive call the lambda body could name the caller's T (x as T), so a value escaped with the wrong type. It's fixed, and pinned in names_the_callers_generic.
  • Round 3 (two reviewers): correctness found nothing. A test gap for the per-lambda cache is filled by one_of_two_lambdas_captures.

Mutant rule. Every mutant ran in a scratch worktree, under timeout 120, after a separate build step.

Note

Medium Risk
This changes which types are inferred for calls with lambda arguments, list literals and field accesses, all in the compiler's call inference. A mistake would reject valid programs or accept unsound ones. The risk is limited by these points:

  • Every new solution is checked against the call before it's used.
  • Three review rounds probed soundness, and their one unsound case is pinned as an error.
  • A per-layer fuzzer comparison shows 0 regressions and 0 unsound variants.

Changes by area:

  • call_inference.rs: the hint rule for an argument's expected type; which lambda parameters are instantiated (generic_parameter_types, names_restored_generics); instantiation in the alternative solve.
  • lambda.rs: LambdaParameter and LambdaBody::captures_generics.
  • list.rs: items past the end of the expected pairs.
  • field.rs: wrapped_at and keeps_reference.
  • compiler.rs: ArgumentFrame::lambda_parameters holds LambdaParameters.
  • rue-hir/database.rs: next_hir_id, hirs_between and symbol_count.
  • tests/types/generic_inference_*: new tests and moved pins.

… and inner pairs

A field of a struct whose type is an untyped lambda parameter's keeps the references to the callee's
generics that are in it, the way an element of a pair does, and so does an element with them deeper
inside, such as `p.first` for `p: ((A, Int), Int)`. The field is reached through the pairs the
struct's type is made of before it's substituted, and is the same type as the substituted one, so
only the inference of the call's generics sees the difference.
@Rigidity
Rigidity added this pull request to stack #449 November 19, 2026 08:31
@Rigidity
Rigidity merged commit 9956bdc into main Nov 19, 2026
6 checks passed
@Rigidity
Rigidity deleted the rigidity/inference-restructure-13e8 branch November 19, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant